Skip to content

refactor: reorganize project#4850

Closed
nxsaken wants to merge 1 commit intohyperledger-iroha:mainfrom
nxsaken:fix/reorganize-project
Closed

refactor: reorganize project#4850
nxsaken wants to merge 1 commit intohyperledger-iroha:mainfrom
nxsaken:fix/reorganize-project

Conversation

@nxsaken
Copy link
Copy Markdown
Contributor

@nxsaken nxsaken commented Jul 16, 2024 •
edited
Loading

Description

This fixes the error with cargo install:

package `.../client/tests/integration/smartcontracts/executor_custom_data_model/Cargo.toml` is a member of the wrong workspace
  • move all binary crates to /bins
  • move all library crates to /libs
  • move executors, smart contracts and triggers to /samples
  • unnest iroha_executor and iroha_trigger from iroha_smart_contract
  • rename crate directories to match their actual names (except nested utility crates)

Benefits

  • binaries can be installed with cargo install
  • separation between binaries and libraries
  • more predictable structure and names

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@nxsaken nxsaken marked this pull request as ready for review July 16, 2024 13:25
@nxsaken nxsaken self-assigned this Jul 16, 2024
@mversic
Copy link
Copy Markdown
Contributor

mversic commented Jul 17, 2024

I think you should break this into several PRs

@mversic mversic mentioned this pull request Jul 17, 2024
Closed
5 tasks
@nxsaken nxsaken changed the title refactor: reorganize project, fix Cargo issue refactor: reorganize project Jul 18, 2024
@nxsaken
refactor: reorganize project
34b7a05 
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@Erigara
Copy link
Copy Markdown
Contributor

Erigara commented Jul 18, 2024

can this error be fixed in less invasive way?

@nxsaken
Copy link
Copy Markdown
Contributor Author

nxsaken commented Jul 18, 2024

Superseded by #4863.

@nxsaken nxsaken closed this Jul 18, 2024
@nxsaken nxsaken mentioned this pull request Jul 24, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@nxsaken nxsaken

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nxsaken @mversic @Erigara