Skip to content

ci: Refactor Sonarqube & DefectDojo job#4605

Merged
nxsaken merged 4 commits intohyperledger-iroha:mainfrom
BAStos525:fix/dops-3186/i2-refactor-sonar-dojo
May 21, 2024
Merged

ci: Refactor Sonarqube & DefectDojo job#4605
nxsaken merged 4 commits intohyperledger-iroha:mainfrom
BAStos525:fix/dops-3186/i2-refactor-sonar-dojo

Conversation

@BAStos525
Copy link
Copy Markdown
Contributor

@BAStos525 BAStos525 commented May 16, 2024

Description

  1. Move workspace_analysis, with_coverage and sonarqube-defectdojo jobs to the new dedicated workflow.
  2. Change docker registries repo for iroha2:dev and iroha2-nightly images.

Linked issue

#4510 #4598

Closes

(should): #4510 #4598

Benefits

Fix clippy and lcov reports uploading to Sonarqube and DefectDojo.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@BAStos525
Copy link
Copy Markdown
Contributor Author

@0x009922 please help to update docker-compose swarm regarding new dev image path

@BAStos525 BAStos525 changed the title [ci] #4510 #4598: Refactor Sonarqube & DefectDojo job [ci]: Refactor Sonarqube & DefectDojo job May 16, 2024
@BAStos525 BAStos525 force-pushed the fix/dops-3186/i2-refactor-sonar-dojo branch 2 times, most recently from e7b6079 to 15ae524 Compare May 16, 2024 15:38
@BAStos525 BAStos525 changed the title [ci]: Refactor Sonarqube & DefectDojo job ci: Refactor Sonarqube & DefectDojo job May 16, 2024
nxsaken
nxsaken previously approved these changes May 17, 2024
@nxsaken nxsaken removed the iroha2 label May 17, 2024
Comment thread .github/workflows/iroha2-dev-lints.yml Outdated
Comment thread .github/workflows/iroha2-dev-lints.yml
@0x009922 0x009922 force-pushed the fix/dops-3186/i2-refactor-sonar-dojo branch from 41c2d07 to 5c44b23 Compare May 17, 2024 08:06
@mversic mversic requested review from nxsaken and s8sato May 17, 2024 13:42
@nxsaken
Copy link
Copy Markdown
Contributor

nxsaken commented May 21, 2024

@BAStos525 can you amend my latest commit to include the sign-off? Turns out GH's inconsistent when signing off commits created from the web UI.

BAStos525 and others added 4 commits May 21, 2024 10:18
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
@BAStos525 BAStos525 force-pushed the fix/dops-3186/i2-refactor-sonar-dojo branch from e983209 to c1099d6 Compare May 21, 2024 07:20
@nxsaken nxsaken merged commit 89e445b into hyperledger-iroha:main May 21, 2024
s8sato added a commit to s8sato/iroha that referenced this pull request Jan 17, 2025
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
s8sato added a commit to s8sato/iroha that referenced this pull request Feb 4, 2025
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
s8sato added a commit to s8sato/iroha that referenced this pull request Feb 4, 2025
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
s8sato added a commit that referenced this pull request Feb 13, 2025
…5289)

* fix: un-flatten enum `Level` to serialize
* feat(cli): add `iroha transaction get` and other important commands
* chore: remove `scripts/tests/tick.json`
* docs: fix invalid links
* ci: exclude from coverage `iroha_cli` `iroha_torii` covered by pytests
* ci: complement #4605: tag not `iroha2:*` but `iroha:*`
* docs: fix lints
* chore: update CHANGELOG.md

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
s8sato added a commit that referenced this pull request Feb 13, 2025
…t commands (#5290)

* fix: un-flatten enum `Level` to serialize
* feat(cli): add `iroha transaction get` and other important commands
* ci: exclude from coverage `iroha_cli` `iroha_torii` covered by pytests
* ci: complement #4605: tag not `iroha2:*` but `iroha:*`
* docs: fix invalid links
* docs: fix lints
* chore: remove `scripts/tests/tick.json`
* chore: update CHANGELOG.md
* chore: minor version bump to `2.0.0-rc.1.1`

Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants