fix(tls): do not shutdown the server on connection timeout errors #1972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Oct 4, 2024
Contributor
Author
|
@djc - Do I need to do anything else to get this merged? |
Contributor
|
Nope! @tottoto any opinions? |
tottoto
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #1948 and #1938
We have a tls server in production and we started seeing instances of the server exiting due to errors in the accept loop after upgrading to version 0.12.2.
We pinned our tonic version to commit sha 474390b and that fixed most of the issues. However we still see shutdowns on connection timeout errors.
Solution
Add
io::ErrorKind::TimedOutto the list of errors to ignore