fix(tls): do not shutdown server on unexpected Eof #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Contributor
Author
|
cc @djc if we can get that into 0.12.3 |
djc
approved these changes
Sep 12, 2024
Contributor
|
LGTM! |
Contributor
|
Hi! Just chiming in to say thank you! We're hitting this issue, which is even worse for us as we have long-lived gRPC streams, that prevent the tonic server from exiting, effectively DoS-ing our APIs if for whatever reason we get non-tls tcp connection. |
LucioFranco
approved these changes
Sep 16, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When receiving non TLS packets (like TCP healtchecks), the server shuts down due to the UnexpectedEof returned by rustls.
Solution
Ignore this error