feat(client): add a TrySendError::message() method#3884
Merged
cratelyn merged 1 commit intohyperium:masterfrom May 6, 2025
Merged
Conversation
this commit introduces a new inherent method to `hyper::client::conn::TrySendError<T>`. this error type includes a `TrySendError::take_message()` method today that will return an owned instance of the inbound message, should the underlying dispatch have been closed before serialization of the message ever began. this commit introduces a new method that allows callers to inspect the message, e.g. to update metrics, without needing to take ownership of the message. Signed-off-by: katelyn martin <git@katelyn.world>
seanmonstar
approved these changes
May 5, 2025
cratelyn
added a commit
to cratelyn/hyper
that referenced
this pull request
May 6, 2025
this commit introduces a new inherent method to `hyper::client::conn::TrySendError<T>`. this error type includes a `TrySendError::into_error()` method today that will consume the `TrySendError<T>`, returning the inner error. this commit introduces a new method that allows callers to inspect the error, e.g. to update metrics, without needing to consume the error. this is akin to hyperium#3884, which added the `TrySendError::message()` method that returns a reference to the `T`-typed message when applicable. Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
added a commit
that referenced
this pull request
May 6, 2025
this commit introduces a new inherent method to `hyper::client::conn::TrySendError<T>`. this error type includes a `TrySendError::into_error()` method today that will consume the `TrySendError<T>`, returning the inner error. this commit introduces a new method that allows callers to inspect the error, e.g. to update metrics, without needing to consume the error. this is akin to #3884, which added the `TrySendError::message()` method that returns a reference to the `T`-typed message when applicable. Signed-off-by: katelyn martin <git@katelyn.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit introduces a new inherent method to
hyper::client::conn::TrySendError<T>.this error type includes a
TrySendError::take_message()method today that will return an owned instance of the inbound message, should the underlying dispatch have been closed before serialization of the message ever began.this commit introduces a new method that allows callers to inspect the message, e.g. to update metrics, without needing to take ownership of the message.