fix(client): don't panic in DNS resolution when task cancelled#2229
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Jun 11, 2020
Merged
fix(client): don't panic in DNS resolution when task cancelled#2229seanmonstar merged 1 commit intohyperium:masterfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
If the runtime is dropped while a DNS request is being made, it can
lead to a panic. This patch checks if the task was cancelled, and
returns a generic IO error instead of panicking in that case.
The following code reproduces the problem on my macOS machine:
```
use hyper::Client;
use tokio::runtime;
type Result<T> = std::result::Result<T, Box<dyn std::error::Error + Send + Sync>>;
fn main() {
let rt = runtime::Builder::new()
.threaded_scheduler()
.core_threads(1)
.enable_all()
.build()
.unwrap();
// spawn a request and then drop the runtime immediately
rt.spawn(fetch_url());
}
async fn fetch_url() -> Result<()> {
let url: hyper::Uri = "http://example.com".parse()?;
let client = Client::builder().build_http::<hyper::Body>();
let res = client.get(url).await?;
println!("Response: {}", res.status());
Ok(())
}
```
seanmonstar
approved these changes
Jun 11, 2020
Member
|
Thanks, very clear explanation! |
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this pull request
Jul 26, 2021
…ium#2229) If the runtime is dropped while a DNS request is being made, it can lead to a panic. This patch checks if the task was cancelled, and returns a generic IO error instead of panicking in that case. The following code reproduces the problem on my macOS machine: ``` use hyper::Client; use tokio::runtime; type Result<T> = std::result::Result<T, Box<dyn std::error::Error + Send + Sync>>; fn main() { let rt = runtime::Builder::new() .threaded_scheduler() .core_threads(1) .enable_all() .build() .unwrap(); // spawn a request and then drop the runtime immediately rt.spawn(fetch_url()); } async fn fetch_url() -> Result<()> { let url: hyper::Uri = "http://example.com".parse()?; let client = Client::builder().build_http::<hyper::Body>(); let res = client.get(url).await?; println!("Response: {}", res.status()); Ok(()) } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the runtime is dropped while a DNS request is being made, it can
lead to a panic. This patch checks if the task was cancelled, and
returns a generic IO error instead of panicking in that case.
The following code reproduces the problem on my macOS machine:
If you think this should be handled differently, please let me know.