Skip to content

Update base64 to 0.21#127

Merged
seanmonstar merged 2 commits into
hyperium:masterfrom
Ayush1325:base64-update
Aug 30, 2023
Merged

Update base64 to 0.21#127
seanmonstar merged 2 commits into
hyperium:masterfrom
Ayush1325:base64-update

Conversation

@Ayush1325

Copy link
Copy Markdown
Contributor

Also added once_cell for caching the new Engine based APIs of base64

Signed-off-by: Ayush Singh ayushsingh1325@gmail.com

@Ayush1325

Copy link
Copy Markdown
Contributor Author

Possibly a duplicate of #123 although the versions are different.

@seanmonstar seanmonstar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar

Copy link
Copy Markdown
Member

Ah, I guess base64 decided to use the 2021 edition, requiring a newer compiler. Sigh. What version is needed?

@Ayush1325

Copy link
Copy Markdown
Contributor Author

Ah, I guess base64 decided to use the 2021 edition, requiring a newer compiler. Sigh. What version is needed?

I think it's 1.57.0. Should I update this PR or would you like to do that separately?

@nicoxxl

nicoxxl commented Mar 27, 2023

Copy link
Copy Markdown

Beware, hyper MSRV is 1.56 : https://github.com/hyperium/hyper/blob/master/docs/MSRV.md

But 1.57.0 was released a little more than one year ago : https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html

@serprex

serprex commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

@Ayush1325 please go ahead & update minrust in .github/workflows/ci.yml

@serprex

serprex commented Apr 23, 2023

Copy link
Copy Markdown
Contributor

@seanmonstar tungstenite opted to switch from base64 crate to data-encoding given how extensive latest changes are: snapview/tungstenite-rs@c6769e3

would you prefer a PR replacing base64 with data-encoding?

@serprex

serprex commented May 22, 2023

Copy link
Copy Markdown
Contributor

Looks like base64 went ahead & bumped MSRV to 1.60 with 0.21.1: marshallpierce/rust-base64#238

Created #139 as alternative to this PR

@Colerar

Colerar commented Aug 26, 2023

Copy link
Copy Markdown

Note: base64 released 0.21.3, and MSRV roll-backed to 1.48.

https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md#0213

Comment thread .github/workflows/ci.yml Outdated
@serprex

serprex commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

@seanmonstar with MSRV issues seeming to be resolved for base64, can this PR progress?

@seanmonstar

Copy link
Copy Markdown
Member

Yea absolutely, let's do it :)

@seanmonstar

Copy link
Copy Markdown
Member

Huh, well looks like with httpdate, we need an MSRV of 1.56 anyways. 🤷

Comment thread Cargo.toml Outdated
@serprex

serprex commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

Created #147 as that msrv change would be unrelated to this PR

Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
@seanmonstar seanmonstar merged commit a8b4181 into hyperium:master Aug 30, 2023
joseluisq pushed a commit to static-web-server/headers-accept-encoding that referenced this pull request Sep 16, 2023
Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Co-authored-by: Sean McArthur <sean@seanmonstar.com>
@serprex serprex mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants