Fix reclaiming reserved capacity (fixes #607) #832
Merged
+109
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm wondering if scheduled resets should just be removed and send_reset be tweaked to not clear the send queue when called implicitly. |
seanmonstar
reviewed
Jan 20, 2025
Reclaiming requested capacity that has not been actually reserved yet is wrong, as this capacity never existed to begin with.
5017247 to
296f4c5
Compare
Contributor
Author
I tried that, but you need the send buffer to queue a reset frame, and you can't reach the send buffer from |
seanmonstar
approved these changes
Jan 20, 2025
GlenDC
added a commit
to plabayo/rama
that referenced
this pull request
Feb 20, 2025
* Fix reclaiming reserved capacity (fixes <hyperium/h2#607>) by @nox in <hyperium/h2#832> * Fix busy loop on shutdown by @seanmonstar in <hyperium/h2#834> * Fix window size decrement of send-closed streams by @nox in <hyperium/h2#830> * Fix handle implicit resets at the right time by @nox in <hyperium/h2#833> * Fix poll_flush after poll_shutdown by @bdbai in <hyperium/h2#836> Co-authored-by: Sean McArthur <sean@seanmonstar.com> Co-authored-by: 包布丁 <htbai1998m@hotmail.com> Co-authored-by: Anthony Ramine <123095+nox@users.noreply.github.com> Co-authored-by: Samuel Tardieu <sam@rfc1149.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reclaiming requested capacity that has not been actually reserved yet is wrong, as this capacity never existed to begin with.