Skip to content

Add caching#6

Merged
hynek merged 7 commits intomainfrom
fix-caching
Aug 21, 2022
Merged

Add caching#6
hynek merged 7 commits intomainfrom
fix-caching

Conversation

@hynek
Copy link
Owner

@hynek hynek commented Aug 20, 2022

Unfortunately, the ** syntax doesn't work outside of our repo.

Trying to set

cache-dependency-path: "${{ github.action_path }}/requirements/tools.txt"

gives me:

Error: Invalid pattern '/home/runner/work/build-and-inspect-python-package/build-and-inspect-python-package/./action/requirements/tools.txt'. Relative pathing '.' and '..' is not allowed.

The old approach of

cache-dependency-path: "**/tools.txt"

gives me:

Error: No file in /home/runner/work/argon2-cffi-bindings/argon2-cffi-bindings matched to [**/tools.txt], make sure you have checked out the target repository

Because the action is hidden somewhere.


Not sure this is currently solvable…

@hynek hynek changed the title Fix caching Add caching Aug 20, 2022
@webknjaz
Copy link
Contributor

Because the action is hidden somewhere.

Not somewhere. IIRC It's under /home/runner/_actions or something like that. I recommend you injecting https://github.com/marketplace/actions/debugging-with-tmate and poking around yourself...

@hynek
Copy link
Owner Author

hynek commented Aug 20, 2022

I could just print ${github.action_path} or probably just replace ./ but that seems icky and might break soon.

But maybe I can do some bash stuff to resolve the path.

@hynek hynek merged commit cb01344 into main Aug 21, 2022
@hynek hynek deleted the fix-caching branch August 21, 2022 04:47
@hynek
Copy link
Owner Author

hynek commented Aug 21, 2022

Fun, it still doesn't work:

No file in /home/runner/work/argon2-cffi/argon2-cffi matched to [/home/runner/work/_actions/hynek/build-and-inspect-python-package/v1.2/requirements/tools.txt], make sure you have checked out the target repository

Looks like we can't refer to our own files at all!?

hynek added a commit that referenced this pull request Aug 21, 2022
This reverts commit cb01344.
@hynek hynek mentioned this pull request Aug 21, 2022
@hynek
Copy link
Owner Author

hynek commented Aug 21, 2022

I'm tracking this issue in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants