Merged
Conversation
hynek
reviewed
Feb 15, 2025
Owner
|
ping? 😇 |
edgarrmondragon
commented
Jun 2, 2025
hynek
requested changes
Jun 12, 2025
Owner
hynek
left a comment
There was a problem hiding this comment.
Thanks for coming back!
Could you exercise the feature somehow in CI, too?
Maybe checking it's correct for the package we use?
0eedde7 to
09b4e2d
Compare
Contributor
Author
Done in cd47733. Let me know what you think. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Hynek!
Do let me know if this going a bit far in scope for this action, but the use case is essentially what I put in the updated example 😄
Similar to #152.