Skip to content

fix(hydro_deploy): use --target-dir instead of environment variable to improve caching#1943

Merged
shadaj merged 1 commit intomainfrom
pr1943
Jul 24, 2025
Merged

fix(hydro_deploy): use --target-dir instead of environment variable to improve caching#1943
shadaj merged 1 commit intomainfrom
pr1943

Conversation

@shadaj
Copy link
Copy Markdown
Member

@shadaj shadaj commented Jul 24, 2025

sccache includes all environment variables starting with CARGO_ in the cache key, so this would cause misses for all trybuild compilation. Along with mozilla/sccache#2424, this improves compilation caching.

… to improve caching

sccache includes all environment variables starting with `CARGO_` in the cache key, so this would cause misses for all trybuild compilation. Along with mozilla/sccache#2424, this improves compilation caching.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f55a56
Status: ✅  Deploy successful!
Preview URL: https://aff27d51.hydroflow.pages.dev
Branch Preview URL: https://pr1943.hydroflow.pages.dev

View logs

@shadaj shadaj requested a review from MingweiSamuel July 24, 2025 22:24
@shadaj shadaj merged commit bea805d into main Jul 24, 2025
16 checks passed
@shadaj shadaj deleted the pr1943 branch July 24, 2025 22:29
jhellerstein pushed a commit that referenced this pull request Jul 25, 2025
… to improve caching (#1943)

sccache includes all environment variables starting with `CARGO_` in the
cache key, so this would cause misses for all trybuild compilation.
Along with mozilla/sccache#2424, this improves
compilation caching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants