Skip to content

Fixes for intermittent test failures on windows.#669

Merged
hoytak merged 3 commits intomainfrom
hoytak/260226-db-windows-intermediate-fix
Feb 27, 2026
Merged

Fixes for intermittent test failures on windows.#669
hoytak merged 3 commits intomainfrom
hoytak/260226-db-windows-intermediate-fix

Conversation

@hoytak
Copy link
Collaborator

@hoytak hoytak commented Feb 27, 2026

This PR addresses two rare but occasional test failures on windows, both due to window's non-synchronous file system behavior.

  • A race condition opening the local test database causing an error.
  • Unwanted cleanup conditions in testing the log preservation can trigger if the test execution is stretched out long enough.
  • A null-termination bug in set_file_metadata that causes it to fail silently if the memory layout is such a way that the string passed in isn't null-terminated. This causes occasional failures in setting the metadata time on linux.

@hoytak hoytak requested a review from seanses February 27, 2026 02:01
@hoytak hoytak merged commit 3a4a2b8 into main Feb 27, 2026
7 checks passed
@hoytak hoytak deleted the hoytak/260226-db-windows-intermediate-fix branch February 27, 2026 15:53
hoytak added a commit that referenced this pull request Feb 28, 2026
This PR addresses two rare but occasional test failures on windows, both
due to window's non-synchronous file system behavior.
- A race condition opening the local test database causing an error.
- Unwanted cleanup conditions in testing the log preservation can
trigger if the test execution is stretched out long enough.
- A null-termination bug in set_file_metadata that causes it to fail
silently if the memory layout is such a way that the string passed in
isn't null-terminated. This causes occasional failures in setting the
metadata time on linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants