Conversation
- also made all diag scripts world executable
There was a problem hiding this comment.
Pull Request Overview
Adds a macOS-specific diagnostics script to complement existing diagnostic tools. The script enables monitoring of hf-xet processes by capturing periodic stack traces and detecting hangs, with automatic debug symbol installation for better debugging capabilities.
- Implements macOS-specific process monitoring using
sampleandlldbtools - Adds automatic detection and core dump generation for hung processes
- Includes automatic download and installation of debug symbols for the installed hf-xet version
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| hf-xet-diag-macos.sh | New macOS diagnostics script with stack tracing, hang detection, and core dump functionality |
| README.md | Documentation update describing the new macOS diagnostics script usage and requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jsulz
left a comment
There was a problem hiding this comment.
Nice! Works for me as well on MacOS 14.5. Did not test on latest MacOS - need to find a good time to walk away from my computer for an hour 😅
I tested on MacOS Sequoia 15.6.1 (24G90) so that is a newer one. My computer is now asking me to update to latest MacOS (renumbered, now 26.0 - sigh.) |
Adds corresponding Diagnostics script for MacOS. Lightly tested with hf-xet 1.1.10 and MacOS 15.6.1 - correctly takes stack traces on interval and writes out to diagnostics folder as expected.
Adds corresponding Diagnostics script for MacOS.
Lightly tested with hf-xet 1.1.10 and MacOS 15.6.1 - correctly takes stack traces on interval and writes out to diagnostics folder as expected.