Allow Duration and byte sizes in constants for easier use.#495
Merged
Conversation
seanses
reviewed
Sep 17, 2025
seanses
reviewed
Sep 17, 2025
seanses
reviewed
Sep 17, 2025
seanses
approved these changes
Sep 17, 2025
seanses
pushed a commit
that referenced
this pull request
Sep 23, 2025
- Duration: Currently, we use a lot of _MS and _SEC suffixes in constants to denote duration. This PR allows std::time::Duration to be used directly, with values such as "10sec" or "100ms" or "1d" translated directly into std::time::Duration. - ByteSize: It also introduces a new utility type, ByteSize, that simply wraps a u64 but allows the user to specify "1mb" or "45gb" as the value when setting constant values. The suffixes mb, mib, kb, kib, gb, gib, b, etc. are all supported, with the default being the raw value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duration: Currently, we use a lot of _MS and _SEC suffixes in constants to denote duration. This PR allows std::time::Duration to be used directly, with values such as "10sec" or "100ms" or "1d" translated directly into std::time::Duration.
ByteSize: It also introduces a new utility type, ByteSize, that simply wraps a u64 but allows the user to specify "1mb" or "45gb" as the value when setting constant values. The suffixes mb, mib, kb, kib, gb, gib, b, etc. are all supported, with the default being the raw value.