Merged
Conversation
Collaborator
hoytak
approved these changes
Jun 12, 2025
jgodlew
approved these changes
Jun 12, 2025
Contributor
jgodlew
left a comment
There was a problem hiding this comment.
This looks good. Good catch! 
Collaborator
|
Merging to cut a new rc wheel for testing. |
seanses
added a commit
that referenced
this pull request
Sep 9, 2025
Removes this custom DNS resolver that forces domain names to be absolute. Using relative domain names is a valid practice in Kubernetes clusters to configure proxy servers, e.g. huggingface/huggingface_hub#3323 The original [PR](#383) that added this resolver was trying to resolve huggingface/huggingface_hub#3155 later appeared to be a problem of user local misconfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that some DNS resolvers struggle to correctly resolve CAS server address and fallback to local search domain (huggingface/huggingface_hub#3155).
This may be due to a wrong DNS resolver configuration (possibly a
ndots>2.This PR implements a custom DNS resolver to force absolute DNS name resolution.