Fix type for teacher_model_init_kwargs when passed as CLI JSON string#5258
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
pushed a commit
that referenced
this pull request
Mar 20, 2026
songhappy
pushed a commit
to songhappy/trl
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type for teacher_model_init_kwargs when passed as CLI JSON string.
transformersThis PR fixes the type annotation for the
teacher_model_init_kwargsfield across multiple configuration classes in the codebase. The change expands the allowed types to includestrin addition todict[str, Any]andNone, taking into account how teacher model initialization arguments can be provided via CLI JSON string.Follow-up to:
GKDConfig,GOLDConfig, andMiniLLMConfig: Updated the type annotation forteacher_model_init_kwargsto acceptdict[str, Any],str, orNoneinstead of justdict[str, Any]orNone.Note
Low Risk
Type-annotation-only change in config classes; behavior should be unchanged aside from improving compatibility with CLI-provided JSON strings.
Overview
Updates experimental trainer config dataclasses (
GKDConfig,GOLDConfig,MiniLLMConfig) to widen the type ofteacher_model_init_kwargsfromdict[str, Any] | Nonetodict[str, Any] | str | None, matchingtransformersbehavior when the value is provided as a CLI JSON string.Written by Cursor Bugbot for commit d934224. This will update automatically on new commits. Configure here.