Simplify logic for structured outputs across vLLM versions#5215
Merged
Conversation
qgallouedec
pushed a commit
that referenced
this pull request
Mar 20, 2026
catherinelee274
pushed a commit
to catherinelee274/trl
that referenced
this pull request
Apr 17, 2026
songhappy
pushed a commit
to songhappy/trl
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify logic for structured outputs across vLLM versions.
This PR refactors the handling of structured output parameters for vLLM generation to improve compatibility across different vLLM versions and simplify the logic for setting structured output options. The main changes focus on unifying the way structured output parameters are imported and used, and on reducing code duplication related to vLLM version checks.
vLLM structured output handling improvements:
StructuredOutputsParamsand its key ingeneration_kwargsbased on the vLLM version, ensuring compatibility with both pre- and post-0.10.2 versions.generation_kwargs, removing duplicated version checks and using a singlestructured_outputs_keyvariable for consistency.Code cleanup:
LLM,RequestOutput, andSamplingParamsonly when vLLM is available, improving import hygiene.