Fix PEFT interlinks in docstrings#4178
Merged
albertvillanova merged 2 commits intoSep 30, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Sep 30, 2025
| Function to preprocess the logits before computing the metrics. Must take in the `logits` and `labels` and | ||
| return the logits to be used for metrics computation. | ||
| peft_config ([`~peft.config.PeftConfig`], *optional*): | ||
| peft_config ([`~peft.PeftConfig`], *optional*): |
Member
There was a problem hiding this comment.
there is a similar mistake in PPO as well
Member
Author
There was a problem hiding this comment.
Oups, I had missed that! 😅
qgallouedec
approved these changes
Sep 30, 2025
qgallouedec
left a comment
Member
There was a problem hiding this comment.
lgtm, ideally if you can fix ppo doctoring as well 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PEFT interlinks in docstrings
The interlink will be properly rendered (as it is already the case for other HF libs, like
transformersordatasets) once this PR indoc-builderis merged: