👩🦯 Fix usage of VLM using text only#4080
Conversation
| @@ -0,0 +1,31 @@ | |||
| """Test for issue #3957 - VLM KeyError fix""" | |||
There was a problem hiding this comment.
Will be deleted before merging
|
cc @qgallouedec for review when you get the time. |
sergiopaniego
left a comment
There was a problem hiding this comment.
Thanks for the fix!
We could add a modified version of the script as a test in test_sft_trainer.py and remove the script
Thanks for your quick reply @sergiopaniego ! Good to merge on my side (but it looks like we still need approval for the workflows to run) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@sergiopaniego do you understand why the tests are failing ? It doesn't look related to my changes ... :x |
|
Hi, thanks for your contribution. I opted for a different approach: when the dataset does not contain images, it can be pre-processed, and there is no point in doing it on the fly. |
This works as well! Thanks for the edit @qgallouedec. |

What
How to review
Test performed
[rank0]: KeyError: 'images'like in sft_gemma3 example doesn't work #3957 but after the fix it is working just fine