🧹 Remove max_batch_tokens, num_blocks and block_size from generation kwargs#4065
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
As a reminder, while |
Member
Author
|
thanks for the feedback @remi-or!
will do! |
McPatate
approved these changes
Sep 23, 2025
kashif
approved these changes
Sep 23, 2025
albertvillanova
left a comment
Member
There was a problem hiding this comment.
LGTM if the test of the change in block_size does not have a negative impact. Otherwise, we should keep the original 128 value.
Member
Author
|
Tried with 0.5B and 1.7B, no difference between block_size=32 and 128👍 |
qgallouedec
added a commit
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These parameters are now automatically computed, see huggingface/transformers#40426