Refactor log_reports.py for Improved Logging, File Processing, and Slack Payload Handling#2249
Merged
qgallouedec merged 9 commits intohuggingface:mainfrom Oct 24, 2024
Merged
Conversation
4 tasks
Contributor
Author
|
hey @qgallouedec , i have made a pr for this issue #2237 , please review all the changes that i have made. |
qgallouedec
reviewed
Oct 24, 2024
qgallouedec
reviewed
Oct 24, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Oct 24, 2024
qgallouedec
reviewed
Oct 24, 2024
Member
|
Thanks for helping improving this @Mefisto04. Can you make sure to run |
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Contributor
Author
|
hey @qgallouedec i have commits all the changes that you have provided, please review this |
qgallouedec
reviewed
Oct 24, 2024
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
…d Slack Payload Handling (huggingface#2249) * Update log_reports.py * comments text update Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> * emoji added Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> * Update scripts/log_reports.py Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> * Update scripts/log_reports.py * style * Update scripts/log_reports.py --------- Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> Co-authored-by: Quentin Gallouédec <quentin.gallouedec@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements to the
log_reports.pyscript, including:Logging Enhancements:
setup_loggingfunction to configure logging with a more detailed format for better debugging.File Processing Refactor:
process_log_filefunction to encapsulate log file processing, reducing redundancy and improving error handling.FileNotFoundErrorandJSONDecodeErrorfor more precise logging.Slack Payload Handling Improvements:
Code Cleanup:
OSErrorcases.These changes aim to make the script more maintainable, enhance logging detail, and improve the reliability of Slack notifications.