fix: validate special token ids against attribute values#45791
Merged
Conversation
Member
|
cc @zucchini-nlp since this was added in #41250 - I think the whole warning branch was probably just never used? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
May 11, 2026
…#45791) fix: validate special token ids by fetching attribute values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
src/transformers/configuration_utils.py:463, the special-token-id validation loop iterated overtext_config, which yields attribute name strings. The subsequentisinstance(value, int)check was therefore always False, so out-of-vocab*_token_idvalues silently passed validation and never produced the intended warning.Fix
Treat the loop variable as the attribute name and fetch the value via
getattrbefore checking the type and range. The warning message now reports the attribute name and its value separately.