Conversation
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey could you give us a bit more info about what this entails to?
|
Added |
|
I'm not sure about this - I think a lot of our library isn't actually fully typed, and type hints are "nice to have" rather than mandatory. Will adding a |
|
@Rocketknight1 No Python project has perfect typing in practice.Errors are generated when the user enables type inference. Without py.typed in this case, errors are triggered for each transformer symbol, and now we can at least provide correct types some symbols and leave |
|
Seems okay to me in that case, but I'll defer to core maintainers since it affects the entire project, cc @ArthurZucker @Cyrilvallez @LysandreJik |
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for the details, LGTM. At some point we did have a file like that.
8db7e42 to
9d5dec9
Compare
|
Merging lots of your PRs now the CI is green, thanks again @cyyever! |
py.typed is a marker file to support typing. See pep 561. It's used to indicate that transformer has typing support in the source code and tools such as mypy and pylint can take advantage of that. Therefore, we don't need an additional pyi file for typing.