Skip to content

Tiny update after #34383#34404

Merged
ydshieh merged 3 commits intomainfrom
fix_empty
Oct 28, 2024
Merged

Tiny update after #34383#34404
ydshieh merged 3 commits intomainfrom
fix_empty

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 25, 2024

What does this PR do?

I forgot a place that needs an update too.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh requested a review from ArthurZucker October 25, 2024 09:45
Comment on lines +550 to +551
if model not in new_failed_tests:
new_failed_tests[model] = {"single-gpu": [], "multi-gpu": []}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix for not having all new failing tests being saved into new_model_failures.json

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗

@ydshieh ydshieh merged commit 9360f18 into main Oct 28, 2024
@ydshieh ydshieh deleted the fix_empty branch October 28, 2024 11:01
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* update

* update

* update

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants