Avoid using context that is not accessable from external contributors#33866
Avoid using context that is not accessable from external contributors#33866
Conversation
|
Hey! 🤗 Thanks for your contribution to the Before merging this pull request, slow tests CI should be triggered. To enable this:
(For maintainers) The documentation for slow tests CI on PRs is here. |
| setup_and_quality_2: | ||
| when: | ||
| not: | ||
| equal: [<<pipeline.project.git_url>>, https://github.com/huggingface/transformers] | ||
| jobs: | ||
| - check_circleci_user | ||
| - check_code_quality | ||
| - check_repository_consistency | ||
| - fetch_tests: | ||
| # [reference] https://circleci.com/docs/contexts/ | ||
| context: |
There was a problem hiding this comment.
This is for private repositories.
(i.e. for some model additions)
There was a problem hiding this comment.
Yeah, I think this is kind of what Henna suggested in her message. As external contributors won't have permission to access TRANSFORMERS_CONTEXT, we should either remove the context: or remove the private contents that users can't access.
| when: | ||
| not: <<pipeline.parameters.nightly>> | ||
| and: | ||
| - equal: [<<pipeline.project.git_url>>, https://github.com/huggingface/transformers] |
There was a problem hiding this comment.
if it is huggingface/transformers : don't use context!
| setup_and_quality_2: | ||
| when: | ||
| not: | ||
| equal: [<<pipeline.project.git_url>>, https://github.com/huggingface/transformers] |
There was a problem hiding this comment.
for private forked repositories (e.g. some model additions): use context
ArthurZucker
left a comment
There was a problem hiding this comment.
Cool, so for private fork, we go though the non-context, will it still work? 🤗
public (i.e. hf/transformers): go without context --> works as it doesn't require the token to get the artifacts |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@ydshieh Thanks for the fix! |
…huggingface#33866) * fix * fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?