Ignore keys on validate_rope#33753
Merged
zucchini-nlp merged 4 commits intohuggingface:mainfrom Oct 4, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Sep 27, 2024
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Nice, thanks! Could you add tests that ensures that:
- A warning is printed when an unneeded key is sent
- The warning isn't printed when
ignore_keysis correctly set
Thanks!
|
Hey! 🤗 Thanks for your contribution to the Before merging this pull request, slow tests CI should be triggered. To enable this:
(For maintainers) The documentation for slow tests CI on PRs is here. |
gante
approved these changes
Oct 4, 2024
Contributor
gante
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing it 🙏
4 tasks
ArthurZucker
pushed a commit
that referenced
this pull request
Oct 7, 2024
* ignore keys on check rope * add tests * fix tests, so maybe better leave at logger lvl
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* ignore keys on check rope * add tests * fix tests, so maybe better leave at logger lvl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #33401. Adds ignore_keys argument when checking received keys and adds
mrope_sectionin qwen2-vl config file as a key we should ignoreI'll open PRs on the hub to change rope type from mrope to default, but until ten decided to leave the comment. For curious users who might open up more issues trying to find why we do manual modifications on rope type :)