Add explicit example for RAG chat templating#33503
Add explicit example for RAG chat templating#33503Rocketknight1 merged 3 commits intohuggingface:mainfrom
Conversation
Rocketknight1
left a comment
There was a problem hiding this comment.
This looks good! I ran the example successfully, and Command-R reported that "interestingly enough", man has always dreamed of destroying the moon. Definitely feel like it was wryly aware that the sources we'd given it might not have been entirely accurate, lol.
I made a suggestion to replace the section you added at the end with a Tip box, but other than that this should be ready to merge soon.
Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
|
Thanks @Rocketknight1 for the tweaking, seemed simpler and clearer to me, I committed your suggestion. 😄 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Yes, it's ready to merge, and don't worry, I can approve it, since it's just a doc change. Thank you, and congratulations on your first PR! |
* Add explicit example for RAG chat templating * Add Tip box and reformulate Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> --------- Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
What does this PR do?
As discussed with @Rocketknight1 in #33421, this commit updates the
chat_templatingdocumentation to:documentsfeature.Hoping to improve readers understanding of the feature.
Might be beneficial to update the Spanish #28936, Japanese #28301 , Korean #20179 , and Chinese #26803 corresponding docs, I did not risk myself as I do not speak those languages fluently enough. es, ja, ko, zh
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
@stevhliu @Rocketknight1