Skip to content

fix from_pretrained in offline mode when model is preloaded in cache#31010

Merged
LysandreJik merged 3 commits intohuggingface:mainfrom
oOraph:dev/offline_mode_fix
May 28, 2024
Merged

fix from_pretrained in offline mode when model is preloaded in cache#31010
LysandreJik merged 3 commits intohuggingface:mainfrom
oOraph:dev/offline_mode_fix

Conversation

@oOraph
Copy link
Contributor

@oOraph oOraph commented May 24, 2024 •
edited
Loading

What does this PR do?

Fixes # (issue)
fix model load in offline mode

Who can review?

@ArthurZucker
@Wauplin

Reproduce:

  1. download a private model from hub
  2. script:
import os

os.environ['TRANSFORMERS_OFFLINE'] = "true"

from transformers.models.auto.modeling_auto import AutoModelForImageClassification

model_id = "Narsil/private"
revision = "main"
kwargs = {'use_auth_token': None}


model = AutoModelForImageClassification.from_pretrained(model_id, revision=revision, **kwargs)

Wauplin
Wauplin reviewed May 24, 2024
View reviewed changes
@oOraph oOraph requested a review from Wauplin May 24, 2024 10:42
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 24, 2024

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

ArthurZucker
ArthurZucker reviewed May 24, 2024
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add this example by using HF hub to downlaod snapshot of a .bin file in a temp repo? and test both the flag to go offline and the local_files_only in from pretrained? 🤗

Wauplin
Wauplin approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oOraph!

@Wauplin Wauplin mentioned this pull request May 24, 2024
Merged
oOraph added 2 commits May 27, 2024 11:19
@oOraph
Unit test to verify fix
0ee0228 
Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@oOraph
fix from_pretrained in offline mode when model is preloaded in cache
257e639 
Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@oOraph oOraph force-pushed the dev/offline_mode_fix branch from 58cc68a to 257e639 Compare May 27, 2024 09:20
@oOraph
Copy link
Contributor Author

oOraph commented May 27, 2024 •
edited
Loading

Thanks! Can you add this example by using HF hub to downlaod snapshot of a .bin file in a temp repo? and test both the flag to go offline and the local_files_only in from pretrained? 🤗

Done @ArthurZucker , added some unit test -> fails before fix, succeeds after
test is ugly but I could not find any cleaner way to do it...

@oOraph
minor: fmt
2eefca1 
Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@oOraph oOraph force-pushed the dev/offline_mode_fix branch from 8035e72 to 2eefca1 Compare May 27, 2024 09:25
@oOraph oOraph requested a review from ArthurZucker May 27, 2024 12:05
LysandreJik
LysandreJik approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LysandreJik LysandreJik merged commit 936ab7b into huggingface:main May 28, 2024
ArthurZucker
ArthurZucker reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://huggingface.co/hf-internal-testing/tiny-random-SiglipForImageClassification/tree/main does not have a bin file, so we are not testing the case we solved before. Otherwise LGTM

ArthurZucker pushed a commit that referenced this pull request May 30, 2024
@oOraph @ArthurZucker
fix from_pretrained in offline mode when model is preloaded in cache (#…
73b180c 
…31010)

* Unit test to verify fix

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>

* fix from_pretrained in offline mode when model is preloaded in cache

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>

* minor: fmt

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>

---------

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
Co-authored-by: Raphael Glon <oOraph@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurZucker ArthurZucker ArthurZucker left review comments

@Wauplin Wauplin Wauplin approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oOraph @HuggingFaceDocBuilderDev @Wauplin @LysandreJik @ArthurZucker