fix jinja2 package version check#29754
Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom Mar 20, 2024
Ricardo-L-C:main
Merged
fix jinja2 package version check#29754Rocketknight1 merged 1 commit intohuggingface:mainfrom Ricardo-L-C:main
Rocketknight1 merged 1 commit intohuggingface:mainfrom
Ricardo-L-C:main
Conversation
Rocketknight1
approved these changes
Mar 20, 2024
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Good catch, this was indeed a mistake in the code!
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
pushed a commit
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix jinja2 package version check
Fixes # (issue)
Incorrect jinja2 package version check #29752
Before submitting
Who can review?
@amyeroberts
Tests
install specific jinja2 package with
pip install jinja2==3.0.0. Other environments have been pointed out in the issue.I test with follow code:
And got the desired output instead of raising an error: