Revert "add attention_mask and position_ids in assisted model"#27523
Merged
patrickvonplaten merged 2 commits intomainfrom Nov 16, 2023
Merged
Revert "add attention_mask and position_ids in assisted model"#27523patrickvonplaten merged 2 commits intomainfrom
patrickvonplaten merged 2 commits intomainfrom
Conversation
This reverts commit 184f60d.
Contributor
|
Hi @patrickvonplaten . Sorry for making this mistake, would you please wait for the new PR merge, it should have fixed the problem. |
Contributor
|
@patrickvonplaten -- @jiqing-feng's PR should fix it :) The PR being reverted here did break speculative decoding for encoder-decoder architectures. CI did not caught it since the non-slow test is based on sample and it had a lucky run. |
Contributor
Author
|
Merging so that distil whisper works again |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…ngface#27523) * Revert "add attention_mask and position_ids in assisted model (huggingface#26892)" This reverts commit 184f60d. * more debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #26892 as it breaks speculative decoding of Whisper