Incorrect setting for num_beams in translation and summarization examples#27519
Merged
Rocketknight1 merged 3 commits intomainfrom Nov 15, 2023
Merged
Incorrect setting for num_beams in translation and summarization examples#27519Rocketknight1 merged 3 commits intomainfrom
Rocketknight1 merged 3 commits intomainfrom
Conversation
4 tasks
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…ples (huggingface#27519) * Remove the torch main_process_first context manager from TF examples * Correctly set num_beams=1 in our examples, and add a guard in GenerationConfig.validate() * Update src/transformers/generation/configuration_utils.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our translation and summarization examples use
Noneas a default value fornum_beams, but this is no longer valid now that we useGenerationConfig. This PR fixes the examples, and also adds a guard inGenerationConfigso thatNonevalues there are replaced with1(and a warning is thrown).Also, while I'm fixing example issues, some of our TF examples use
main_process_first- this is a Torch function, and is not necessary because TF handles distributed training very differently. Since it looks like it could cause problems depending on whether Torch is also present, I'm removing it from all of the TF examples.Fixes #27505