Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
reviewed
Nov 7, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for digging into this and fixing!
For updating the test, is it necessary to update the number of training steps
amyeroberts
approved these changes
Nov 7, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for fixing!
Happy to merge if @ydshieh is happy :)
This was referenced Nov 8, 2023
Collaborator
Just wondering where the is target of alignment (i.e. the pytorch tests). Otherwise, looks good to me as I trust you that the update makes sense (due to the change in |
ydshieh
approved these changes
Nov 8, 2023
Contributor
Author
|
@ydshieh for how many steps that example script takes. For the torch ones it’s 10, here it’s 2 :) |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* Fix example tests from failing * CHange thresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tweaks the inputs to the accelerate tests to align with the ones in the pytorch tests, which was causing test failures. (Plus some fixes in Accelerate main)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ydshieh @amyeroberts