Conversation
ydshieh
commented
Oct 31, 2023
| runner_failed = True if runner_env_status is not None and runner_env_status != "success" else False | ||
| # runner_not_available = True if runner_status is not None and runner_status != "success" else False | ||
| # runner_failed = True if runner_env_status is not None and runner_env_status != "success" else False | ||
| # Let's keep the lines regardig runners' status (we might be able to use them again in the future) |
ydshieh
commented
Oct 31, 2023
Comment on lines
+779
to
+780
| runner_not_available = False | ||
| runner_failed = False |
Collaborator
Author
There was a problem hiding this comment.
set to False (so no failure)
|
The documentation is not available anymore as the PR was closed or merged. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
Disable runner check Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now our CIs run on AWS runners, and they are spun up when a action is triggered and removed afterward, it doesn't make sense to check the runner status as before (where the runners existed forever).