Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
Oct 30, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for updating!
We might want to have a dataset fixture which is just a small subset of this (or an equivalent) dataset so we're remain independent of changes on the hub like this
Collaborator
Author
|
That is in the plan :-) |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* Use mozilla-foundation/common_voice_11_0 * Update expected values * Update expected values * For test_word_time_stamp_integration --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix some tests using
"common_voice".Errors:
and
We can load the same dataset using
"mozilla-foundation/common_voice_6_1", but this requires passingtokenwhich is not good for testing purpose.So I change it to
"mozilla-foundation/common_voice_11_0"but update expected outputs.