device agnostic pipelines testing#27129
Merged
ydshieh merged 2 commits intohuggingface:mainfrom Oct 31, 2023
Merged
Conversation
Contributor
Author
|
verified with Mac-Studio 
|
5f90dad to
025994f
Compare
Contributor
|
cc @ydshieh |
cc7c4bd to
35eff72
Compare
35eff72 to
9f34d7b
Compare
Contributor
Author
|
@ydshieh Marking this ready for review :-) |
amyeroberts
approved these changes
Oct 31, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for working on this and improving our tests! ❤️
Happy to merge once @ydshieh approves
ydshieh
approved these changes
Oct 31, 2023
Collaborator
ydshieh
left a comment
There was a problem hiding this comment.
Great! I would like to run them before merge. Will update here.
| model="hf-internal-testing/tiny-random-distilbert", | ||
| framework="pt", | ||
| device=torch.device("cpu"), | ||
| device=torch_device, |
Collaborator
There was a problem hiding this comment.
not sure why it was hardcoded to cpu previously
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Collaborator
|
test run results look good, so merge! Thanks again @statelesshz |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* device agnostic pipelines testing * pass torch_device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #25654 (comment)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @ydshieh