Provide alternative when warning on use_auth_token#27105
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
approved these changes
Oct 27, 2023
Collaborator
ydshieh
left a comment
There was a problem hiding this comment.
Much better than what I did ❤️ , thank you a lot!
Contributor
Author
|
Simply added 4 words, nothing more 😉 |
amyeroberts
approved these changes
Oct 27, 2023
Contributor
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding this and improving the warnings!
ArthurZucker
approved these changes
Oct 27, 2023
Contributor
Author
|
Well, 3 reviews so I'll merged! 😄 Thanks everyone :) |
Contributor
|
thanks for the prompt response @Wauplin |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the warning message when a user uses
use_auth_tokeninstead oftoken. In some cases, the deprecation warning states thatuse_auth_tokenis deprecated without mentioningtokenas an alternative. This PR fixes this.Opened this issue after some users got confused they wouldn't be able to authenticate anymore (see Forum). cc @radames who pinged me there.