Skip to content

[T5Tokenizer] Fix fast and extra tokens#27085

Merged
ArthurZucker merged 11 commits intohuggingface:mainfrom
ArthurZucker:t5-nits
Oct 27, 2023
Merged

[T5Tokenizer] Fix fast and extra tokens#27085
ArthurZucker merged 11 commits intohuggingface:mainfrom
ArthurZucker:t5-nits

Conversation

@ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Oct 26, 2023

What does this PR do?

fixes #26951, where the extra ids were checked differently for fast and slow

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 26, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ArthurZucker ArthurZucker merged commit aa4198a into huggingface:main Oct 27, 2023
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* v4.35.dev.0

* nit t5fast match t5 slow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T5Tokenizer load fails when added special tokens and saved with save_pretrained

3 participants