Handle unsharded Llama2 model types in conversion script#27069
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Oct 26, 2023
Merged
Handle unsharded Llama2 model types in conversion script#27069ArthurZucker merged 1 commit intohuggingface:mainfrom
ArthurZucker merged 1 commit intohuggingface:mainfrom
Conversation
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey! Thanks for opneing a PR. Overall i agree with you, num shards should be more resilient but correct me if I am wrong no checkpoints with 1 shard != 7b and 7b-chatwere released ?
Contributor
Author
|
There's currently two options for unsharded |
ArthurZucker
approved these changes
Oct 26, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Ok, this doesn't change much in the code path so why not
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…#27069) Handle all unshared models types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the unsharded condition to check previously looked-up
num_shardsinstead of model type. This is important because multiple model types are uncharded (7B and 7BF)Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.