[Trainer / GC] Add gradient_checkpointing_kwargs in trainer and training arguments#27068
Merged
younesbelkada merged 6 commits intohuggingface:mainfrom Oct 30, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Oct 25, 2023
src/transformers/training_args.py
Outdated
| gradient_checkpointing_kwargs: dict = field( | ||
| default=None, | ||
| metadata={ | ||
| "help": "Gradient checkpointing key word arguments. Will be passed to `torch.utils.checkpoint.checkpoint` through `model.gradient_checkpointing_enable`." |
Collaborator
There was a problem hiding this comment.
could you add why anyone would want to pass antyhing and what is supported?
Collaborator
There was a problem hiding this comment.
And a small small test!
Collaborator
|
Also why does it partially fix the issue |
Contributor
Author
|
It partially fixes the issue because I need huggingface/peft#1036 to be merged to fix the bug with respect to PEFT models |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
… training arguments (huggingface#27068) * add `gradient_checkpointing_kwargs` in trainer and training arguments * add comment * add test - currently failing * now tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partially fixes: huggingface/trl#912
Following #27020 it is important to propagate
gradient_checkpointing_kwargsinTraineras wellcc @ArthurZucker