Add default_to_square_for_size to CLIPImageProcessor#26965
Merged
Conversation
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
few very small nits
| image_mean: Optional[Union[float, List[float]]] = None, | ||
| image_std: Optional[Union[float, List[float]]] = None, | ||
| do_convert_rgb: bool = True, | ||
| default_to_square_for_size: bool = False, |
Collaborator
There was a problem hiding this comment.
Suggested change
| default_to_square_for_size: bool = False, | |
| use_square_size: bool = False, |
or something like this!
Comment on lines
+87
to
+88
| default_to_square_for_size (`bool`, *optional*, defaults to `False`): | ||
| The value to be passed to `get_size_dict` as `default_to_square` when computing the image size. |
Collaborator
There was a problem hiding this comment.
let's say what it changes depending on this values!
Collaborator
Author
There was a problem hiding this comment.
use_square_size (`bool`, *optional*, defaults to `False`):
The value to be passed to `get_size_dict` as `default_to_square` when computing the image size. If the
`size` argument in `get_size_dict` is an `int`, it determines whether to default to a square image or not.
Note that this attribute is not used in computing `crop_size` via calling `get_size_dict`.
Comment on lines
+87
to
+90
| use_square_size (`bool`, *optional*, defaults to `False`): | ||
| The value to be passed to `get_size_dict` as `default_to_square` when computing the image size. If the | ||
| `size` argument in `get_size_dict` is an `int`, it determines whether to default to a square image or not. | ||
| Note that this attribute is not used in computing `crop_size` via calling `get_size_dict`. |
Collaborator
There was a problem hiding this comment.
Okay good enough for me, would be better to know what size are used if false for example
Collaborator
Author
There was a problem hiding this comment.
I take this from the original get_size_dict.
def get_size_dict(
...
...
default_to_square (`bool`, *optional*, defaults to `True`):
If `size` is an int, whether to default to a square image or not.
other places like def get_resize_output_image_size
has sth like
How to convert `size` when it is a single int. If set to `True`, the `size` will be converted to a square
(`size`,`size`). If set to `False`, will replicate
[`torchvision.transforms.Resize`](https://pytorch.org/vision/stable/transforms.html#torchvision.transforms.Resize)
with support for resizing only the smallest edge and providing an optional `max_size`.
but this method has more logic than the canonical get_size_dict
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Oct 20, 2023
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I am pinging @amyeroberts so that she sees it when she comes back. Feel free to merge
Collaborator
Author
|
Thanks a lot ! |
Collaborator
Author
|
I forgot to change this line to will do it but wait on next Monday to merge |
i4never
pushed a commit
to i4never/transformers
that referenced
this pull request
Oct 25, 2023
…#26965) * fix * fix * fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…#26965) * fix * fix * fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
default_to_square_for_sizetoCLIPImageProcessor.As in the file, we also have
crop_size = get_size_dict(crop_size, default_to_square=True, param_name="crop_size"), so I give the namedefault_to_square_for_sizeforget_size_dict(size, default_to_square=default_to_square_for_size)to avoid confusion.Otherwise, I can give it
default_to_square, and we may adddefault_to_square_for_crop_sizelater (or in this PR).