Change default max_shard_size to smaller value#26942
Merged
younesbelkada merged 5 commits intomainfrom Oct 23, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
julien-c
reviewed
Oct 19, 2023
| The maximum size for a checkpoint before being sharded. Checkpoints shard will then be each of size | ||
| lower than this size. If expressed as a string, needs to be digits followed by a unit (like `"5MB"`). | ||
| We default it to 2GB in order for models to be able to run easily on free-tier google colab instances | ||
| without CPU OOM issues. |
Member
There was a problem hiding this comment.
maybe 5GB would be a better trade off no?
Contributor
Author
There was a problem hiding this comment.
Yeah makes sense
ArthurZucker
approved these changes
Oct 23, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Good catch, we can't enforce the default is the same as from pretrained but no big deal
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* Update modeling_utils.py * fixup * let's change it to 5GB * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, we can also change that value dynamically with respect to model size - with this change large models will end up having many shards.
cc @ArthurZucker