fix logit-to-multi-hot conversion in example#26936
Merged
younesbelkada merged 3 commits intohuggingface:mainfrom Oct 23, 2023
Merged
fix logit-to-multi-hot conversion in example#26936younesbelkada merged 3 commits intohuggingface:mainfrom
younesbelkada merged 3 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Should we not apply sigmoid ?
Otherwise fine with me. There is a way to pass a specific function to the trainer: preprocess_logits_for_metrics which can apply the sigmoid otherwise (but not needed here)
ArthurZucker
approved these changes
Oct 20, 2023
Contributor
Author
|
@ArthurZucker I've updated the comment for educational purpose. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* fix logit to multi-hot converstion * add comments * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #26830 . The bug might lead to difference in measuring multi-label acc (Slightly higher precision and lower recall).
@younesbelkada Would you please review.