Fix Fuyu image scaling bug#26918
Merged
ArthurZucker merged 3 commits intohuggingface:mainfrom Oct 20, 2023
Merged
Conversation
It could produce negative padding and hence inference errors for certain image sizes.
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Oct 19, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Member
Author
|
|
Collaborator
|
He might have missed it let's merge this 😉 |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* Fix Fuyu image scaling bug It could produce negative padding and hence inference errors for certain image sizes. * Fix aspect ratio scaling test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coordinates are reversed, see
transformers/src/transformers/image_transforms.py
Line 328 in 574a538
It could produce negative padding and hence inference errors for certain image sizes, as identified in the Fuyu demo
Happy to write a small test in the morning.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@molbap @ArthurZucker @LysandreJik