[FA-2 / Mistral] Supprot fa-2 + right padding + forward#26912
Merged
younesbelkada merged 1 commit intohuggingface:mainfrom Oct 19, 2023
Merged
[FA-2 / Mistral] Supprot fa-2 + right padding + forward#26912younesbelkada merged 1 commit intohuggingface:mainfrom
FA-2 / Mistral] Supprot fa-2 + right padding + forward#26912younesbelkada merged 1 commit intohuggingface:mainfrom
Conversation
ArthurZucker
approved these changes
Oct 19, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Sounds about right, we don't really have another way to check if we are generating, so LGTM
|
Hi @younesbelkada @ArthurZucker, Thanks for your contribution ! This patch was removed in this RP. After tracking the commit history, I think it should be added back ? Best, |
Contributor
Author
|
Thansk for noticing @zhjohnchan ! Just made: #27125 that should revert the behaviour of this PR |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…ace#26912) supprot fa-2 + right padding + forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #26877
There should be no reason to not support right padding + pure forward as the reason to not support generate + right padding + fa-2 is the cache mechanism for that case that slices the cache from the left.
cc @ArthurZucker