Fix and re-enable ConversationalPipeline tests#26907
Merged
Rocketknight1 merged 2 commits intomainfrom Oct 19, 2023
Merged
Conversation
Member
Author
|
Looks good - ready to merge after review! |
ArthurZucker
approved these changes
Oct 19, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Maybe limiting the max length to the position embed would be more full proof!
LGTM
Member
Author
|
@ArthurZucker I tried that, but sometimes the tests get very slow when |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* Fix and re-enable conversationalpipeline tests * Fix the batch test so the change only applies to conversational pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug didn't turn out to be too bad - some models just had very short
max_position_embeddingsin their test configs, which meant the conversation tests generated outputs that were too long. Limitingmax_new_tokensseems to have fixed it, but I'm running other tests to be sure!