Merged
Conversation
- Fixed broken links I hope this small contribution adds value to this project.
stevhliu
reviewed
Oct 18, 2023
Member
stevhliu
left a comment
There was a problem hiding this comment.
Thanks for fixing the links!
One more minor change and then we can merge :)
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Contributor
Author
|
I've committed the suggestion you can merge it now. |
Contributor
Author
|
@stevhliu btw on line 90 there's jax installation if that's what you meant you . |
stevhliu
reviewed
Oct 19, 2023
Member
stevhliu
left a comment
There was a problem hiding this comment.
We should try to keep the translation as close to the English one as possible. There's a mention of Jax installation on line 259 🙂
I added a link to the Jax doc for you if you don't mind, let me know if that translates correctly!
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* Update README_hd.md - Fixed broken links I hope this small contribution adds value to this project. * Update README_hd.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this small contribution adds value to this project.