Bring back set_epoch for Accelerate-based dataloaders#26850
Merged
LysandreJik merged 6 commits intomainfrom Oct 26, 2023
Merged
Bring back set_epoch for Accelerate-based dataloaders#26850LysandreJik merged 6 commits intomainfrom
set_epoch for Accelerate-based dataloaders#26850LysandreJik merged 6 commits intomainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
The tests seem to error out, so waiting for this.
Could you link to which pr removed it?
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
This was referenced Oct 18, 2023
ArthurZucker
approved these changes
Oct 25, 2023
LysandreJik
approved these changes
Oct 26, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…26850) * Working tests! * Fix sampler * Fix * Update src/transformers/trainer.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * Fix check * Clean --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR brings back the
set_epochlogic and solves the last remaining regression from the accelerate integration. Resuming training should now be exactly identical. (Introduced due to an incomplete implementation in #24028)Linked with huggingface/accelerate#2057
Fixes # (issue)
fixes #26541
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@LysandreJik @ArthurZucker