deprecate function get_default_device in tools/base.py#26774
Merged
amyeroberts merged 3 commits intohuggingface:mainfrom Oct 31, 2023
Merged
deprecate function get_default_device in tools/base.py#26774amyeroberts merged 3 commits intohuggingface:mainfrom
get_default_device in tools/base.py#26774amyeroberts merged 3 commits intohuggingface:mainfrom
Conversation
been officially released
PartialState().default_device as is hasPartialState().default_device as is has been officially released
muellerzr
approved these changes
Oct 13, 2023
Contributor
muellerzr
left a comment
There was a problem hiding this comment.
Thanks! @ArthurZucker should this be on a deprecation cycle for the function name? Otherwise looks great to me
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Yes! As @muellerzr mentions, I think we should leave it for now, with a deprecation warning mention that we'll remove it soon and that the accelerate version should be used!
PartialState().default_device as is has been officially releasedget_default_device in tools/base.py
muellerzr
reviewed
Oct 24, 2023
ArthurZucker
approved these changes
Oct 24, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM with the proposed changes!
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
Contributor
Author
|
this PR is ready to be merged :) @muellerzr @ArthurZucker |
Contributor
Author
|
cc @amyeroberts |
Merged
5 tasks
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
…ce#26774) * get default device through `PartialState().default_device` as is has been officially released * apply code review suggestion * apply code review suggestion Co-authored-by: Zach Mueller <muellerzr@gmail.com> --------- Co-authored-by: Zach Mueller <muellerzr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.