[JAX] Replace uses of jnp.array in types with jnp.ndarray.#26703
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Oct 10, 2023
Merged
[JAX] Replace uses of jnp.array in types with jnp.ndarray.#26703ArthurZucker merged 1 commit intohuggingface:mainfrom
jnp.array in types with jnp.ndarray.#26703ArthurZucker merged 1 commit intohuggingface:mainfrom
Conversation
`jnp.array` is a function, not a type: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.array.html so it never makes sense to use `jnp.array` in a type annotation. Presumably the intent was to write `jnp.ndarray` aka `jax.Array`. Co-authored-by: Peter Hawkins <phawkins@google.com>
sanchit-gandhi
approved these changes
Oct 10, 2023
Contributor
sanchit-gandhi
left a comment
There was a problem hiding this comment.
Lovely, thanks for updating the type hints @hvaara!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
ArthurZucker
approved these changes
Oct 10, 2023
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for updating this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jnp.arrayis a function, not a type:https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.array.html so it never makes sense to use
jnp.arrayin a type annotation. Presumably the intent was to writejnp.ndarrayakajax.Array.For a similar PR in
diffusers, please see huggingface/diffusers#4719.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @pcuenca @patrickvonplaten