[JAX] Replace uses of jnp.array in types with jnp.ndarray.#4719
Merged
pcuenca merged 2 commits intohuggingface:mainfrom Oct 9, 2023
Merged
[JAX] Replace uses of jnp.array in types with jnp.ndarray.#4719pcuenca merged 2 commits intohuggingface:mainfrom
jnp.array in types with jnp.ndarray.#4719pcuenca merged 2 commits intohuggingface:mainfrom
Conversation
`jnp.array` is a function, not a type: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.array.html so it never makes sense to use `jnp.array` in a type annotation. Presumably the intent was to write `jnp.ndarray` aka `jax.Array`. Change uses of `jnp.array` to `jnp.ndarray`. Co-authored-by: Peter Hawkins <phawkins@google.com>
Contributor
Contributor
Author
|
@pcuenca Does this LGTY? |
pcuenca
approved these changes
Oct 9, 2023
Member
|
@hvaara Yes, sorry! Running tests just in case. |
Contributor
Author
|
No worries. Yes, please run the tests in case I've missed or broken something 😄 I have a very similar PR incoming to |
5 tasks
Contributor
Author
|
Thanks for the reviews! |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…ngface#4719) `jnp.array` is a function, not a type: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.array.html so it never makes sense to use `jnp.array` in a type annotation. Presumably the intent was to write `jnp.ndarray` aka `jax.Array`. Change uses of `jnp.array` to `jnp.ndarray`. Co-authored-by: Peter Hawkins <phawkins@google.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…ngface#4719) `jnp.array` is a function, not a type: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.array.html so it never makes sense to use `jnp.array` in a type annotation. Presumably the intent was to write `jnp.ndarray` aka `jax.Array`. Change uses of `jnp.array` to `jnp.ndarray`. Co-authored-by: Peter Hawkins <phawkins@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
jnp.arrayis a function, not a type:https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.array.html so it never makes sense to use
jnp.arrayin a type annotation.Presumably the intent was to write
jnp.ndarrayakajax.Array. Change uses ofjnp.arraytojnp.ndarray.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.